Variadic parameters in PHP8 can have int|string key #725
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| <?php | ||
|
|
||
| namespace Bug2600; | ||
|
|
||
| use function PHPStan\Testing\assertType; | ||
|
|
||
| class Foo | ||
| { | ||
| /** | ||
| * @param mixed ...$x | ||
| */ | ||
| public function doFoo($x = null) { | ||
| $args = func_get_args(); | ||
| assertType('mixed', $x); | ||
| assertType('array', $args); | ||
| } | ||
|
|
||
| /** | ||
| * @param mixed ...$x | ||
| */ | ||
| public function doBar($x = null) { | ||
| assertType('mixed', $x); | ||
| } | ||
|
|
||
| /** | ||
| * @param mixed $x | ||
| */ | ||
| public function doBaz(...$x) { | ||
| assertType('array<int|string, mixed>', $x); | ||
| } | ||
|
|
||
| /** | ||
| * @param mixed ...$x | ||
| */ | ||
| public function doLorem(...$x) { | ||
| assertType('array<int|string, mixed>', $x); | ||
| } | ||
|
|
||
| public function doIpsum($x = null) { | ||
| $args = func_get_args(); | ||
| assertType('mixed', $x); | ||
| assertType('array', $args); | ||
| } | ||
| } | ||
|
|
||
| class Bar | ||
| { | ||
| /** | ||
| * @param string ...$x | ||
| */ | ||
| public function doFoo($x = null) { | ||
| $args = func_get_args(); | ||
| assertType('string|null', $x); | ||
| assertType('array', $args); | ||
| } | ||
|
|
||
| /** | ||
| * @param string ...$x | ||
| */ | ||
| public function doBar($x = null) { | ||
| assertType('string|null', $x); | ||
| } | ||
|
|
||
| /** | ||
| * @param string $x | ||
| */ | ||
| public function doBaz(...$x) { | ||
| assertType('array<int|string, string>', $x); | ||
| } | ||
|
|
||
| /** | ||
| * @param string ...$x | ||
| */ | ||
| public function doLorem(...$x) { | ||
| assertType('array<int|string, string>', $x); | ||
| } | ||
| } | ||
|
|
||
| function foo($x, string ...$y): void | ||
| { | ||
| assertType('mixed', $x); | ||
| assertType('array<int|string, string>', $y); | ||
| } | ||
|
|
||
| function ($x, string ...$y): void { | ||
| assertType('mixed', $x); | ||
| assertType('array<int|string, string>', $y); | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| <?php // lint >= 7.4 | ||
|
|
||
| namespace Bug4902; | ||
|
|
||
| use function PHPStan\Testing\assertType; | ||
|
|
||
| /** | ||
| * @template T-wrapper | ||
| */ | ||
| class Wrapper { | ||
| /** @var T-wrapper */ | ||
| public $value; | ||
|
|
||
| /** | ||
| * @param T-wrapper $value | ||
| */ | ||
| public function __construct($value) { | ||
| $this->value = $value; | ||
| } | ||
|
|
||
| /** | ||
| * @template T-unwrap | ||
| * @param Wrapper<T-unwrap> $wrapper | ||
| * @return T-unwrap | ||
| */ | ||
| function unwrap(Wrapper $wrapper) { | ||
| return $wrapper->value; | ||
| } | ||
|
|
||
| /** | ||
| * @template T-wrap | ||
| * @param T-wrap $value | ||
| * | ||
| * @return Wrapper<T-wrap> | ||
| */ | ||
| function wrap($value): Wrapper | ||
| { | ||
| return new Wrapper($value); | ||
| } | ||
|
|
||
|
|
||
| /** | ||
| * @template T-all | ||
| * @param Wrapper<T-all> ...$wrappers | ||
| */ | ||
| function unwrapAllAndWrapAgain(Wrapper ...$wrappers): void { | ||
| assertType('array<int|string, T-all (method Bug4902\Wrapper::unwrapAllAndWrapAgain(), argument)>', array_map(function (Wrapper $item) { | ||
| return $this->unwrap($item); | ||
| }, $wrappers)); | ||
| assertType('array<int|string, T-all (method Bug4902\Wrapper::unwrapAllAndWrapAgain(), argument)>', array_map(fn (Wrapper $item) => $this->unwrap($item), $wrappers)); | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| <?php | ||
|
|
||
| namespace VariadicParameterPHP8; | ||
|
|
||
| use function PHPStan\Testing\assertType; | ||
|
|
||
| function foo(...$args) | ||
| { | ||
| assertType('array<int|string, mixed>', $args); | ||
| assertType('mixed', $args['foo']); | ||
| assertType('mixed', $args['bar']); | ||
| } | ||
|
|
||
| function bar(string ...$args) | ||
| { | ||
| assertType('array<int|string, string>', $args); | ||
| } | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why it's no longer tested on PHP 8+? If there are different asserts, please create
bug-2600-php8.phpfor that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.