Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faster TypeCombinator::compareTypesInUnion() #742

Merged
merged 1 commit into from Oct 26, 2021

Conversation

voku
Copy link
Contributor

@voku voku commented Oct 26, 2021

I only played a little with the code, and compared the results via blackfire. Maybe I missed something here, and we can't return null directly?

https://blackfire.io/profiles/compare/e4356233-ed30-49c5-8e01-2d7c163a3ef4/graph

Bildschirmfoto von 2021-10-26 21-13-17

@ondrejmirtes ondrejmirtes merged commit af02bd8 into phpstan:master Oct 26, 2021
@ondrejmirtes
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants