New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing iterable stubs #796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New generic classes also need to be added to this array
Line 25 in 89c16a6
skipCheckGenericClasses: [] |
The integration tests found this error:
The
What I suspect that this is some kind of mix up between implicit and explicit Can you please debug this? Thanks. |
I didn't leave a comment after my last push to warn you that I was watching this issue. I'm going to debug it, I'll let you know when I found something. Thanks. |
I'd be happy if the error "type has no value type specified in iterable type" wasn't started to be reported in this situation even after this PR - so this build should continue to be green even for Composer codebase. |
Hi @ondrejmirtes after working a little on this PR, I've to admit that I'm not sure how to fix this issue. Couldn't we update the integration tests? |
One idea - try to rebase on top of dev-master, it might be fixed. |
Thank you! I merged it and will deal with the errors on master :) |
Thanks @ondrejmirtes You make an awesome work with |
Some
iterable
class missing in stubs.This PR add some of them:
FilterIterator
,CallbackFilterIterator
&RecursiveCallbackFilterIterator
.