Add rules for operands in arithmetic operations

[Majkl578]

• Require array or int/float operands in +.
• Require int/float operands in -/*///**/%.

[carusogabriel]

Maybe we can extend it to +=, -=, ++, etc

[Majkl578]

If this one gets merged, I'd like to also add support for:

• ++/--/+/-
• +=/-=/*=//=/**=/%=
• bitwise operators / shifts / assignments

[JanTvrdik]

This needs to use isSubtypeOf instead of instanceof.

[Majkl578]

I guess I am a bit lost in this undocumented typesystem. :)

isSubtypeOf() is defined on CompoundType while Rule only accepts Type.

I tried:

$acceptedType = new UnionType([new IntegerType(), new FloatType()]);
return $acceptedType->accepts($leftType) && $acceptedType->accepts($rightType);

With no lucḱ (got bunch of internal errors).

[JanTvrdik]

Sorry, I meant isSuperTypeOf (isSubTypeOf is mostly internal helper used for inversion of control). accepts() will also work if you want to allow mixed.

I tried (…) got bunch of internal errors

That's odd. The code looks fine. What errors did you get?

[Majkl578]

It was only happening during tests, didn't find you how to enable debug mode for them...

Anyway updated to isSuperTypeOf, could you review now?

[carusogabriel]

@Majkl578 Why not refactor it to one single class and deal with each operand?

[Majkl578]

@carusogabriel PHPStan\Rules\Operators\OperandsInArithmeticDivision::getNodeType() requires to return string so it'd be unnecessary work/abstraction for type & message & specific behavior (like +) imho.

[ondrejmirtes]

isSuperTypeOf should be used to be consistent with other similar checks in the core.

On Fri, 4 May 2018 at 21:47, Jan Tvrdík ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/Rules/Operators/OperatorRuleHelper.php <#15 (comment)> : > @@ -0,0 +1,25 @@ +<?php declare(strict_types = 1); + +namespace PHPStan\Rules\Operators; + +use PHPStan\Type\FloatType; +use PHPStan\Type\IntegerType; +use PHPStan\Type\Type; + +class OperatorRuleHelper +{ + + public static function isValidForArithmeticOperation(Type $leftType, Type $rightType): bool + { + if (!$leftType instanceof IntegerType && !$leftType instanceof FloatType) { Sorry, I meant isSuperTypeOf (isSubTypeOf is mostly internal helper used for *inversion of control*). accepts() will also work if you want to allow mixed. I tried (…) got bunch of internal errors That's odd. The code looks fine. What errors did you get? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#15 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGZuBqNftp-kJeuiVO00z3Ljwc4JVeFks5tvLA1gaJpZM4TzHDl> .

-- Ondřej Mirtes

[Majkl578]

Btw. this doesn't support GMP, but PHPStan currently does not support resource scopes/types so it's currently impossible to implement correctly. What to do, ignore for now?;
Edit: GMP is object as of 5.5+ so it's safe to ignore GMP resource. But still can't be implemented since GMP + GMP operation produces ErrorType.

[Majkl578]

Rebased.

Anything needed here? I'd like to continue with other operators (comparison, bitwise).

[ondrejmirtes]

Thanks! Looking forward to the next set of rules! 👍 (I also suggest checking for strings on both sides of concat $str1 . $str2)