Revert wrong typehint for getSession

phpstan · Jan 15, 2023 · d89a521 · d89a521
1 parent fca0834
commit d89a521
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 11 deletions.
diff --git a/stubs/Symfony/Component/HttpFoundation/Request.stub b/stubs/Symfony/Component/HttpFoundation/Request.stub
@@ -26,11 +26,6 @@ class Request
 	 */
 	public $cookies;
 
-    /**
-     * @return \Symfony\Component\HttpFoundation\Session\Session
-     */
-    public function getSession();
-
     /**
      * @return string[]
      */

diff --git a/tests/Type/Symfony/data/request_get_session.php b/tests/Type/Symfony/data/request_get_session.php
@@ -1,14 +1,14 @@
 <?php declare(strict_types = 1);
 
-use Symfony\Component\HttpFoundation\Session\Session;
+use Symfony\Component\HttpFoundation\Session\SessionInterface;
 use function PHPStan\Testing\assertType;
 
 /** @var \Symfony\Component\HttpFoundation\Request $request */
 $request = doRequest();
 
 $session1 = $request->getSession();
-assertType(Session::class, $request->getSession());
+assertType(SessionInterface::class, $request->getSession());
 
 if ($request->hasSession()) {
-	assertType(Session::class, $request->getSession());
+	assertType(SessionInterface::class, $request->getSession());
 }
diff --git a/tests/Type/Symfony/data/request_get_session_null.php b/tests/Type/Symfony/data/request_get_session_null.php
@@ -1,14 +1,14 @@
 <?php declare(strict_types = 1);
 
-use Symfony\Component\HttpFoundation\Session\Session;
+use Symfony\Component\HttpFoundation\Session\SessionInterface;
 use function PHPStan\Testing\assertType;
 
 /** @var \Symfony\Component\HttpFoundation\Request $request */
 $request = doRequest();
 
 $session1 = $request->getSession();
-assertType(Session::class . '|null', $request->getSession());
+assertType(SessionInterface::class . '|null', $request->getSession());
 
 if ($request->hasSession()) {
-	assertType(Session::class, $request->getSession());
+	assertType(SessionInterface::class, $request->getSession());
 }