Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check integerish values #5

Merged
merged 1 commit into from
Feb 23, 2019
Merged

check integerish values #5

merged 1 commit into from
Feb 23, 2019

Conversation

mavimo
Copy link
Contributor

@mavimo mavimo commented Dec 12, 2018

No description provided.

@mavimo
Copy link
Contributor Author

mavimo commented Dec 12, 2018

This may need rebase once #2 is merged

The failure is fixed in #4

@mavimo mavimo mentioned this pull request Dec 12, 2018
Merged
@ondrejmirtes
Copy link
Member

This is weird - the result should lead to int|string. Can you rebase and investigate why it isn't the case? Thanks.

@mavimo
Copy link
Contributor Author

mavimo commented Jan 4, 2019

@ondrejmirtes I'll check ASAP, thx for feedback

@mavimo mavimo changed the title check integrish values check integerish values Feb 23, 2019
@mavimo
Copy link
Contributor Author

mavimo commented Feb 23, 2019 •
edited

@ondrejmirtes was a typo, integrish instead of integerish (missing E after G)
Also added an extra fix since CI is broken

@ondrejmirtes ondrejmirtes merged commit a5d6fa7 into phpstan:master Feb 23, 2019
@ondrejmirtes
Copy link
Member

Thanks!

@ondrejmirtes ondrejmirtes mentioned this pull request Mar 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mavimo @ondrejmirtes