Introducing ParameterReflection::isPassedByReference()

src/Analyser/NodeScopeResolver.php

@@ -683,21 +683,21 @@ private function hasStatementEarlyTermination(Node $statement, Scope $scope): bo
 	/**
 	 * @param \PhpParser\Node\Expr $functionCall
 	 * @param \PHPStan\Analyser\Scope $scope
-	 * @return null|\ReflectionParameter[]
+	 * @return null|\PHPStan\Reflection\ParameterReflection[]
 	 */
 	private function findParametersInFunctionCall(Expr $functionCall, Scope $scope)
 	{
 		if ($functionCall instanceof FuncCall && $functionCall->name instanceof Name) {
 			if ($this->broker->hasFunction($functionCall->name, $scope)) {
-				return $this->broker->getFunction($functionCall->name, $scope)->getNativeReflection()->getParameters();
+				return $this->broker->getFunction($functionCall->name, $scope)->getParameters();
 			}
 		} elseif ($functionCall instanceof MethodCall && is_string($functionCall->name)) {
 			$type = $scope->getType($functionCall->var);
 			if ($type->getClass() !== null && $this->broker->hasClass($type->getClass())) {
-				$classReflection = $this->broker->getClass($type->getClass())->getNativeReflection();
+				$classReflection = $this->broker->getClass($type->getClass());
 				$methodName = $functionCall->name;
-				if ($classReflection->hasMethod($methodName)) {
-					return $classReflection->getMethod($methodName)->getParameters();
+				if ($classReflection->hasMethod((string) $methodName)) {
+					return $classReflection->getMethod((string) $methodName)->getParameters();
 				}
 			}
 		}

src/Reflection/ParameterReflection.php

@@ -13,4 +13,6 @@ public function isOptional(): bool;
 
 	public function getType(): Type;
 
+	public function isPassedByReference(): bool;
+
 }

src/Reflection/Php/DummyOptionalParameter.php

@@ -14,10 +14,14 @@ class DummyOptionalParameter implements ParameterReflection
 	/** @var \PHPStan\Type\Type  */
 	private $type;
 
-	public function __construct(string $name, Type $type)
+	/** @var bool */
+	private $passedByReference;
+
+	public function __construct(string $name, Type $type, bool $passedByReference = false)
 	{
 		$this->name = $name;
 		$this->type = $type;
+		$this->passedByReference = $passedByReference;
 	}
 
 	public function getName(): string
@@ -35,4 +39,9 @@ public function getType(): Type
 		return $this->type;
 	}
 
+	public function isPassedByReference(): bool
+	{
+		return $this->passedByReference;
+	}
+
 }

src/Reflection/Php/PhpParameterReflection.php

@@ -83,4 +83,9 @@ public function getType(): Type
 		return $this->type;
 	}
 
+	public function isPassedByReference(): bool
+	{
+		return $this->reflection->isPassedByReference();
+	}
+
 }