Disallow console.log

phpstan · Mar 24, 2023 · 4501314 · 4501314
1 parent cbfb23d
commit 4501314
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/website/src/js/handlers.ts b/website/src/js/handlers.ts
@@ -41,7 +41,6 @@ ko.bindingHandlers.codeMirror = {
 		}
 
 		const hover = hoverTooltip((view, pos, side) => {
-			console.log('here');
 			const currentErrors: PHPStanError[] = allBindings.get('codeMirrorErrors');
 			const line = view.state.doc.lineAt(pos);
 			const lineErrors: string[] = [];

diff --git a/website/src/js/merch.ts b/website/src/js/merch.ts
@@ -14,7 +14,7 @@ $(async () => {
 			merchSale: new MerchSaleViewModel(),
 		});
 	} catch (e) {
-		console.log(e);
+		console.error(e);
 		ko.applyBindings({
 			hasFatalError: true,
 			mainMenu: new MainMenuViewModel(),

diff --git a/website/tslint.json b/website/tslint.json
@@ -16,7 +16,7 @@
 			2
 		],
 		"max-line-length": [false],
-		"no-console": [false],
+		"no-console": [true, "log"],
 		"no-require-imports": false,
 		"no-var-requires": false,
 		"object-literal-sort-keys": false,