PhpMethodReflection - fixed isDeprecated(), isInternal(), isFinal()

phpstan · Aug 17, 2019 · 765179c · 765179c
1 parent a02404b
commit 765179c
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 3 deletions.
diff --git a/src/Reflection/Php/BuiltinMethodReflection.php b/src/Reflection/Php/BuiltinMethodReflection.php
@@ -48,4 +48,8 @@ public function getReturnType(): ?\ReflectionType;
 	 */
 	public function getParameters(): array;
 
+	public function isFinal(): bool;
+
+	public function isInternal(): bool;
+
 }
diff --git a/src/Reflection/Php/FakeBuiltinMethodReflection.php b/src/Reflection/Php/FakeBuiltinMethodReflection.php
@@ -92,6 +92,16 @@ public function isVariadic(): bool
 		return false;
 	}
 
+	public function isFinal(): bool
+	{
+		return false;
+	}
+
+	public function isInternal(): bool
+	{
+		return false;
+	}
+
 	public function getReturnType(): ?\ReflectionType
 	{
 		return null;

diff --git a/src/Reflection/Php/NativeBuiltinMethodReflection.php b/src/Reflection/Php/NativeBuiltinMethodReflection.php
@@ -80,6 +80,16 @@ public function isDeprecated(): bool
 		return $this->reflection->isDeprecated();
 	}
 
+	public function isFinal(): bool
+	{
+		return $this->reflection->isFinal();
+	}
+
+	public function isInternal(): bool
+	{
+		return $this->reflection->isInternal();
+	}
+
 	public function isVariadic(): bool
 	{
 		return $this->reflection->isVariadic();

diff --git a/src/Reflection/Php/PhpMethodReflection.php b/src/Reflection/Php/PhpMethodReflection.php
@@ -409,17 +409,17 @@ public function getDeprecatedDescription(): ?string
 
 	public function isDeprecated(): bool
 	{
-		return $this->isDeprecated;
+		return $this->reflection->isDeprecated() || $this->isDeprecated;
 	}
 
 	public function isInternal(): bool
 	{
-		return $this->isInternal;
+		return $this->reflection->isInternal() || $this->isInternal;
 	}
 
 	public function isFinal(): bool
 	{
-		return $this->isFinal;
+		return $this->reflection->isFinal() || $this->isFinal;
 	}
 
 	public function getThrowType(): ?Type