Generalize filtered array with maybe falsey values

phpstan · Jun 18, 2018 · 941684d · 941684d
1 parent 9e6ab0b
commit 941684d
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 5 deletions.
diff --git a/src/Type/Php/ArrayFilterFunctionReturnTypeReturnTypeExtension.php b/src/Type/Php/ArrayFilterFunctionReturnTypeReturnTypeExtension.php
@@ -84,15 +84,22 @@ public function removeFalsey(Type $type): Type
 			$keys = $type->getKeyTypes();
 			$values = $type->getValueTypes();
 
+			$generalize = false;
+
 			foreach ($values as $offset => $value) {
-				if (!$falseyTypes->isSuperTypeOf($value)->yes()) {
-					continue;
-				}
+				$isFalsey = $falseyTypes->isSuperTypeOf($value);
 
-				unset($keys[$offset], $values[$offset]);
+				if ($isFalsey->yes()) {
+					unset($keys[$offset], $values[$offset]);
+				} elseif ($isFalsey->maybe()) {
+					$values[$offset] = TypeCombinator::remove($values[$offset], $falseyTypes);
+					$generalize = true;
+				}
 			}
 
-			return new ConstantArrayType(array_values($keys), array_values($values));
+			$filteredArray = new ConstantArrayType(array_values($keys), array_values($values));
+
+			return $generalize ? $filteredArray->generalize() : $filteredArray;
 		}
 
 		$keyType = $type->getIterableKeyType();

diff --git a/tests/PHPStan/Analyser/NodeScopeResolverTest.php b/tests/PHPStan/Analyser/NodeScopeResolverTest.php
@@ -4144,6 +4144,10 @@ public function dataArrayFunctions(): array
 				'array(\'a\' => 1)',
 				'array_filter($union)',
 			],
+			[
+				'array<int, int|true>',
+				'array_filter($withPossiblyFalsey)',
+			],
 		];
 	}
 

diff --git a/tests/PHPStan/Analyser/data/array-functions.php b/tests/PHPStan/Analyser/data/array-functions.php
@@ -56,6 +56,13 @@
 	$union['b'] = false;
 }
 
+/** @var bool $bool */
+$bool = doFoo();
+/** @var int $integer */
+$integer = doFoo();
+
+$withPossiblyFalsey = [$bool, $integer, '', 'a' => 0];
+
 /** @var array<string, int> $generalStringKeys */
 $generalStringKeys = doFoo();