Fixed dead code detection with isset()

phpstan · Mar 19, 2019 · b43cc2c · b43cc2c
1 parent 066e606
commit b43cc2c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/src/Analyser/Scope.php b/src/Analyser/Scope.php
@@ -395,11 +395,12 @@ private function resolveType(Expr $node): Type
 				if ($var instanceof Expr\Variable && is_string($var->name)) {
 					$variableType = $this->resolveType($var);
 					$isNullSuperType = (new NullType())->isSuperTypeOf($variableType);
-					if ($this->hasVariableType($var->name)->no() || $isNullSuperType->yes()) {
+					$has = $this->hasVariableType($var->name);
+					if ($has->no() || $isNullSuperType->yes()) {
 						return new ConstantBooleanType(false);
 					}
 
-					if (!$isNullSuperType->no()) {
+					if ($has->maybe() || !$isNullSuperType->no()) {
 						$result = new BooleanType();
 					}
 					continue;

diff --git a/tests/PHPStan/Rules/DeadCode/data/unreachable.php b/tests/PHPStan/Rules/DeadCode/data/unreachable.php
@@ -36,4 +36,20 @@ public function doLorem()
 		// this is why...
 	}
 
+	/**
+	 * @param \stdClass[] $all
+	 */
+	public function doIpsum(array $all)
+	{
+		foreach ($all as $a) {
+
+		}
+
+		if (isset($a)) {
+			throw new \Exception();
+		}
+
+		var_dump($a);
+	}
+
 }