Fixed wrong parameter number for openssl_open

phpstan · Oct 26, 2017 · da31968 · da31968
1 parent 3c3ebdf
commit da31968
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/src/Reflection/FunctionReflection.php b/src/Reflection/FunctionReflection.php
@@ -196,6 +196,17 @@ public function getParameters(): array
 					true
 				);
 			}
+
+			if (
+				$this->reflection->getName() === 'openssl_open'
+				&& count($this->parameters) === 5
+			) {
+				$this->parameters[4] = new DummyParameter(
+					'method',
+					new StringType(),
+					true
+				);
+			}
 		}
 
 		return $this->parameters;

diff --git a/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php b/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php
@@ -159,6 +159,10 @@ public function testCallToWeirdFunctions()
 				'Function mysqli_fetch_all invoked with 3 parameters, 1-2 required.',
 				35,
 			],
+			[
+				'Function openssl_open invoked with 6 parameters, 4-5 required.',
+				37,
+			],
 		]);
 	}
 

diff --git a/tests/PHPStan/Rules/Functions/data/call-to-weird-functions.php b/tests/PHPStan/Rules/Functions/data/call-to-weird-functions.php
@@ -33,3 +33,5 @@
 mysqli_fetch_all(new mysqli_result()); // OK
 mysqli_fetch_all(new mysqli_result(), MYSQLI_ASSOC); // OK
 mysqli_fetch_all(new mysqli_result(), MYSQLI_ASSOC, true); // should report 3 parameters given, 1-2 required
+openssl_open('', $open, '', openssl_get_privatekey('')); // OK
+openssl_open('', $open, '', openssl_get_privatekey(''), 'foo', 'bar'); // should report 6 parameters, 4-5 required.