PHPDoc tag @var for property fooRepo contains generic type FooRepository<Foo> but class FooRepository is not generic

[AnjaLiebermann]

In my Symfony4 project I have installed

"phpstan/phpstan": "^0.12.65",
"phpstan/phpstan-doctrine": "^0.12.26",

and when I run phpstan it complains that

PHPDoc tag @var for property App\Domain\RegardsService::$testimonialRepo contains 
generic type App\Repository\TestimonialRepository<App\Entity\Testimonial>
but class App\Repository\TestimonialRepository is not generic.

My class TestimonialRepository does exist and contains some additional methods.

My notation in the calling class looks like this:

class RegardsService implements RegardsServiceInterface
{
    private EntityManagerInterface $entityManager;
    /** @var TestimonialRepository<Testimonial> */
    private ObjectRepository $testimonialRepo;
 ....

I tried checkGenericClassInNonGenericObjectType: false in the phpstan.neon file, but it does change nothing.

If I remove the phpDoc, then phpstan complains, that it doesn't know the additional methods.

What do I have to do to let phpstan accept the code?

<?php

declare(strict_types=1);

namespace App\Repository;

use App\Entity\Testimonial;
use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
use Doctrine\Common\Persistence\ManagerRegistry;
use Doctrine\Common\Persistence\ObjectRepository;

/**
 * @method Testimonial|null find($id, $lockMode = null, $lockVersion = null)
 * @method Testimonial|null findOneBy(array $criteria, array $orderBy = null)
 * @method Testimonial[]    findAll()
 * @method Testimonial[]    findBy(array $criteria, array $orderBy = null, $limit = null, $offset = null)
 */
class TestimonialRepository extends ServiceEntityRepository implements ObjectRepository
{
    public function __construct(ManagerRegistry $registry)
    {
        parent::__construct($registry, Testimonial::class);
    }

    /**
     * @uses \App\Command\DeleteTestimonialsCommand
     *
     * @return mixed
     */
    public function deleteByDate($deleteDate)
    {
        $qb = $this->getEntityManager()->createQueryBuilder();
        $query = $qb->delete(Testimonial::class, 't')
            ->where('t.dateCreated <= \'' . $deleteDate . '\'')
            ->getQuery();

        return $query->getResult();
    }

    public function getCountByResignationReasonField(int $value): int
    {
        $qb = $this->getEntityManager()->createQueryBuilder();

        $query = $qb->select('count(t)')
            ->from(Testimonial::class, 't')
            ->where('t.resignationReason = ' . $value);

        return $query->getQuery()->getSingleScalarResult();
    }

    public function getCountByProfession(): array
    {
        $counter = [];
        $sql = 'SELECT profession_id, count(profession_id) as count
            FROM testimonial te
            GROUP BY profession_id';

        $stmt = $this->getEntityManager()
                     ->getConnection()
                     ->prepare($sql);
        $stmt->execute();

        $res = $stmt->fetchAllAssociative();
        foreach ($res as $value) {
            $counter[$value['profession_id']] = $value['count'];
        }

        return $counter;
    }
}

[ondrejmirtes]

Can you post the code of TestimonialRepository?

[ondrejmirtes]

You don’t have phpstan-doctrineinstalled at all it seems. This shouldn’t happen. Or you don’t have the versions from the first post.

[AnjaLiebermann]

I checked the vendor directory and did a composer update to be sure. I found the library and composer didn't install anything new regarding phpstan or phpstan-doctrine
It is installed with Version 0.12.26

[ondrejmirtes]

Do you have phpstan/extension-installer, or did you put phpstan-doctrine/extension.neon in includes section of your phpstan.neon? https://github.com/phpstan/phpstan-doctrine/#installation

[AnjaLiebermann]

Yes that was the missing!
Thank you for your help!

[ondrejmirtes]

You're welcome :)