Using goto to skip code

[pauljherring]

Given the last issue I submitted turned out to be not an issue because I was doing something silly, I thought I'd try here first.

Consider (https://phpstan.org/r/396ec258-69a7-4eb8-b5f2-651be79aca25):

<?php declare(strict_types = 1);

/** 
  * @return string|false
  */
function string_or_false(){
	if (rand(1,2)==1)
		return "string";
	return false;
}

/**
  * @param string $s
  * @return void
  */
function takes_string(string $s){
	echo $s;
}

$a = string_or_false();
if ($a === false)
	goto end;

takes_string($a); // line 24

end:
	echo "finished";

This reports:

24 | Parameter #1 $s of function takes_string expects string, string|false given.

Given that line 24 won't be executed if $a is false, is this intended? Or am I doing something silly again?

Context for using goto: this cropped up in my test suite - I don't want further tests after certain failures to occur, so I skip them using goto end; so the final part of the test (recording the results so far, e.g.) can happen. I suppose I could do something with exceptions and finally if I have to, but that's merely syntactic sugar that's doing the same thing as this.

[pauljherring]

I suppose I could do something with exceptions and finally if I have to

To save others the bother for this bit:

https://phpstan.org/r/392661a4-f07f-4756-870b-4e7976f9ddeb:

<?php declare(strict_types = 1);

/** 
  * @return string|false
  */
function string_or_false(){
	if (rand(1,2)==1)
		return "string";
	return false;
}

/**
  * @param string $s
  * @return void
  */
function takes_string(string $s){
	echo $s;
}

try{
	$a = string_or_false();
	if ($a === false)
		throw new Exception("x");

	takes_string($a); 
}catch(Exception $e){
	echo $e->getMessage();
}finally{
	echo "finished";
}

No errors.

[ondrejmirtes]

Hi, goto isn't yet supported/understood by PHPStan. You don't have to refactor your code, you can simply persuade it with inline @var: https://phpstan.org/r/5a16273a-a927-4c0c-ae70-f7df3c5c6228

Pleaase open a bug report (https://github.com/phpstan/phpstan/issues/new?assignees=&labels=&template=Bug_report.md) with the original code sample, thanks.

[pauljherring]

Pleaase open a bug report

#4674