Imprecise composer autoload_files

[bytestream]

Is there a way to stub imprecise composer autoload_files?

The motivation here is Laravel 6.x has $vendorDir . '/laravel/framework/src/Illuminate/Foundation/helpers.php', and the factory() function has an incorrect PHPDoc block which was fixed in Laravel 7.x

PHPStan stubFiles to override factory() are ignored as others have noted in larastan/larastan#434 (comment)

It's not possible to use PHPStan bootstrapFiles because composer calls helpers.php and registers the function before the bootstrap file.

The only workaround I have at the moment is to use a phpstan base line.

[ondrejmirtes]

Hi, if I understand the problem correctly, it's that the function is defined as:

    function factory()
    {
        $factory = app(EloquentFactory::class);

        $arguments = func_get_args();

        if (isset($arguments[1]) && is_string($arguments[1])) {
            return $factory->of($arguments[0], $arguments[1])->times($arguments[2] ?? null);
        } elseif (isset($arguments[1])) {
            return $factory->of($arguments[0])->times($arguments[1]);
        }

        return $factory->of($arguments[0]);
    }

But PHPStan complains with: Function factory invoked with 1 parameter, 0 required

Three points:

1. Stub files aren't meant to override this as this isn't a PHPDoc problem, but a function signature problem.
2. It should already work in PHPStan because the function calls func_get_args() but PHPStan probably inspects a different file, I don't know what's going on there. For that to be fixed, you should isolate the problem by creating a minimal repository that shows the bug, and open a Bug report issue.
3. If I understand it correctly, you can fix your problem by updating to Laravel 7.x.

Am I right?

[bytestream]

The function is defined as mentioned but with the following doc block:

    /**
     * Create a model factory builder for a given class, name, and amount.
     *
     * @param  dynamic  class|class,name|class,amount|class,name,amount
     * @return \Illuminate\Database\Eloquent\FactoryBuilder
     */

PHPStan complains with: Function factory invoked with 1 parameter, 0 required

Correct

It should already work in PHPStan

Doesn't the docblock override the function signature (in phpstan)?

If I understand it correctly, you can fix your problem by updating to Laravel 7.x.

Correct, but not feasible - hence the question.

[ondrejmirtes]

The PHPDoc has no bearing on the PHPStan's output in this case.

It should already work in PHPStan because PHPStan reads that the function body contains func_get_args(). See an example: https://phpstan.org/r/181ef927-67f6-42c5-83d2-2348edf238f7

Why it doesn't work in this particular case is something that could be debugged and possibly fixed.

[bytestream]

I've opened #4753 with a reproducer