No warning with ignores, no warning with them removed

[mvorisek]

I through when phpstan ignores are in the code, to finish phpstan without errors errors must be present.

But when I tried to remove some ignores in mvorisek/atk4-hintable-mirror@ec5ddc8, to my suprise, phpstan does not show any error. So I can not reply on phpstan that all present ignores are needed?

Is this a bug or why is that?

[ondrejmirtes]

I can't run it locally, the composer config version 1.999999 trick does no longer work:

atk4-hintable-mirror develop $ composer config version 1.999999
atk4-hintable-mirror develop $ composer install
No lock file found. Updating dependencies instead of installing from lock file. Use composer update over composer install if you do not have a lock file.
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires atk4/data ^3.0 || dev-develop -> satisfiable by atk4/data[dev-develop].
    - atk4/data dev-develop requires mahalux/atk4-hintable ~1.2.1 -> satisfiable by mahalux/atk4-hintable[1.2.1] from composer repo (https://repo.packagist.org) but mahalux/atk4-hintable[1.999999] from root package repo has higher repository priority. The packages with higher priority do not match your constraint and are therefore not installable. See https://getcomposer.org/repoprio for details and assistance.

[mvorisek]

Direct install fixed in mvorisek/atk4-hintable-mirror@59c91d1

Steps to reproduce:

1. checkout & composer install
2. run phpstan - no errors
3. git revert ec5ddc8 (no phpstan ignores)
4. run phpstan again - also no errors

[ondrejmirtes]

I figured it out. Traits analysis is special. Traits are analyzed as many times as they are used by analysed classes. So traits used zero times in a project are analysed zero times.

[mvorisek]

The traits are used in the tests.

For ex. Mvorisek\Atk4\Hintable\Core\MethodTrait trait is used in Mvorisek\Atk4\Hintable\Tests\Core\MethodMock class.

[ondrejmirtes]

Yeah, unmatched ignores are not reported in traits because it's not practical - you might set to ignore it in one context but the error might not show up in another context, reporting an unused ignore.

[mvorisek]

Makes sense if the traits are used in another project. Feel free to mark as answered.