Clarifications on when array shapes are enforced

[herndlm]

Hi, I have pretty much a beginner question. This confused me the second time already :)

Just showing a snippet is easier to understand, see https://phpstan.org/r/77a8e65b-dd07-4c4b-bc8c-76a32243d553
Is it expected/correct that Foo::fromArray1($data); is not erroring there?

[herndlm]

I guess https://phpstan.org/writing-php-code/phpdoc-types#array-shapes

This feature enables usage of strong types in codebases where arrays of various specific shapes are passed around functions and methods.

This is different from general arrays that mandate that all the keys and values must be of a specific homogeneous type. Array shapes allow each key and value to be different.

explains everything. God, but I think I fell the second time into the array shape inside general array trap :/

[flobee]

looking for the same t the moment. defining nested array. not much examples found. not really willed defined exact matches of array which then not scale when adding or removing stuff because one has to update the annotations everywhere... hmm. may be we dont know better at the moment

[herndlm]

not sure if we're talking about the same thing, but maybe https://phpstan.org/writing-php-code/phpdoc-types#local-type-aliases is interesting for you too. if the arrays get too complex though, maybe you should start using some kind of value object / DTO instead

[flobee]

not sure if we're talking about the same thing, but maybe https://phpstan.org/writing-php-code/phpdoc-types#local-type-aliases is interesting for you too. if the arrays get too complex though, maybe you should start using some kind of value object / DTO instead

both a little, having only DTO objects (mostly abstract) but not still that familar with phpstan. I found my solution already because of your report at the given link! thx for reply

[ondrejmirtes]

Foo::fromArray1($data); could/should report an error on level 9 but I guess that $data consists of ArrayType with implicit MixedType, not explicit MixedType. It can be seen in IsArrayFunctionTypeSpecifyingExtension. My bet is that if you modify that to return explicit MixedType, the error is going to be reported.

[herndlm]

Thx, I'll check that out

[herndlm]

that was it! created phpstan/phpstan-src#1191