Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch statements that cover all possibilities should not need default #1016

Closed
muglug opened this issue May 18, 2018 · 2 comments · Fixed by phpstan/phpstan-src#1561
Closed

Comments

@muglug
Copy link
Contributor

muglug commented May 18, 2018

With value types, everything is known absolutely

foreach ([1, 2, 3] as $i) {
  switch ($i) {
    case 1:
      $a = "hello";
      break;
    case 2:
      $a = "goodbye";
      break;
    case 3:
      $a = "hello again";
      break;
  }

  echo $a;
}

Expected: No issue
Actual: Variable $a might not be defined.

@Firehed
Copy link
Contributor

Firehed commented Nov 13, 2020

Probably not news, but this applies to known sets from constant matching too: https://phpstan.org/r/62a3a993-ae11-4a35-8fd3-a0e73376f1c5 (not sure what the internal terminology is for this, but the pseudo-enums)

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants