"Instanceof static" is treated erroneously as "instanceof self"

[kiler129]

Bug report

A statement $foo instanceof static is treated like the static is always the same class as the class where statement is placed. This is obviously wrong, and the easiest example will be to imagine an abstract class which does such check.

Code snippet that reproduces the problem

Running example: https://3v4l.org/O87Qc
Analysis: https://phpstan.org/r/d6cb91f9-e428-4652-a8b0-16ee03ff6759

Currently the analysis reports Result of && is always false. for $x !== null && !($x instanceof static) where ?foo $x

Expected output

No error is expected. Psalm recently fixed the same problem: https://psalm.dev/r/4223401cd8

[muglug]

I fixed by treating this comparison identically to $x === $this

[phpstan-bot]

@kiler129 After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-6: Result of && is always false.
+No errors

[ondrejmirtes]

Fixed: phpstan/phpstan-src@4acbc6c

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.