Too few arguments in SprintfFunctionDynamicReturnTypeExtension

[stepanets]

Bug report

When analyzing code like this:
$sql = sprintf('UPDATE {{%loans}} SET field=1');
i get
Warning: sprintf(): Too few arguments in /var/www/html/vendor/phpstan/phpstan/src/Type/Php/SprintfFunctionDynamicReturnTypeExtension.php on line 39
in console during progress run

/var/www/html # vendor/bin/phpstan analyze --memory-limit=2G -c phpstan.neon

Warning: sprintf(): Too few arguments in /var/www/html/vendor/phpstan/phpstan/src/Type/Php/SprintfFunctionDynamicReturnTypeExtension.php on line 39
 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

Code snippet that reproduces the problem

$sql = sprintf('UPDATE {{%loans}} SET field=1');

PHPStan - PHP Static Analysis Tool 0.11.12

parameters:
    level: max
    reportMagicProperties: false
    autoload_files:
        - %rootDir%/../../yiisoft/yii2/Yii.php

PHP 7.1.30 (cli) (built: Jun 18 2019 00:54:58) ( NTS )

Expected output

without warnings

[mergeable]

This bug report is missing a link to reproduction on phpstan.org.
It will most likely be closed after manual review.

[ondrejmirtes]

Yes, this is a bug, thanks. Also, the wrong sprintf should be picked up by the rule but isn't:

• https://phpstan.org/r/db9709bd-d954-42f8-87d5-0192ed79cadf
• https://3v4l.org/MX0cW

[staabm]

The fix needs to be in https://github.com/phpstan/phpstan-src/blob/c471c7b050e0929daf432288770de673b394a983/src/Rules/Functions/PrintfParametersRule.php and/or https://github.com/phpstan/phpstan-src/blob/c471c7b050e0929daf432288770de673b394a983/src/Type/Php/SprintfFunctionDynamicReturnTypeExtension.php

[staabm]

I tried reproducing the reported warning on php 7.4 (since phpstan no longer 7.1 which is the one the OP used).
I also tested on php 8.1.
Can't reproduce the warning using phpstan/phpstan-src@0f1bfb5, maybe it was fixed in the meantime.

I cannot test on 7.2 with my setup.

---

regarding the argument count problem I created a fix in phpstan/phpstan-src#2041

[phpstan-bot]

@ondrejmirtes After the latest push in 1.10.x, PHPStan now reports different result with your code snippet:

@@ @@
-No errors
+3: Call to sprintf contains 1 placeholder, 0 values given.

Full report

Line	Error
3	Call to sprintf contains 1 placeholder, 0 values given.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.