Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extending "SimpleXMLElement" did not work as expected #4222

Closed
voku opened this issue Dec 11, 2020 · 3 comments
Closed

Extending "SimpleXMLElement" did not work as expected #4222

voku opened this issue Dec 11, 2020 · 3 comments

Comments

@voku
Copy link
Contributor

voku commented Dec 11, 2020

Bug report

SimpleXMLElement->addChild() will return "static" and not "SimpleXMLElement"

Code snippet that reproduces the problem

https://phpstan.org/r/a05cfee2-e145-4812-9850-a4bb2f858376

https://3v4l.org/USJWu

Expected output

no error
@ondrejmirtes
Copy link
Member

Return type of the method needs to be updated in functionMap: https://github.com/phpstan/phpstan-src/blob/d4f746e30ed9b37bba20aea364695504c2d94a13/resources/functionMap.php#L10233

@voku voku mentioned this issue Dec 11, 2020
Merged
@ondrejmirtes
Copy link
Member

Fixed by: phpstan/phpstan-src#407

voku added a commit to voku/phpstorm-stubs that referenced this issue Dec 12, 2020
@voku
"SimpleXMLElement" -> will return static
57fe4b1 
-> fix for phpstan/phpstan#4222
isfedorov pushed a commit to JetBrains/phpstorm-stubs that referenced this issue Dec 14, 2020
@voku @isfedorov
"SimpleXMLElement" -> will return static
2afe09a 
-> fix for phpstan/phpstan#4222
isfedorov pushed a commit to isfedorov/phpstorm-stubs that referenced this issue Dec 15, 2020
@voku @isfedorov
"SimpleXMLElement" -> will return static
f17ecb0 
-> fix for phpstan/phpstan#4222
@github-actions
Copy link

github-actions bot commented May 4, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ondrejmirtes @voku