Importing a trait and changing visibility is ignored

[ruudk]

Bug report

<?php declare(strict_types = 1);

interface RecordsMessages
{
    public function record(object $message): void;
}

trait PrivateMessageRecorderCapabilities
{
    protected function record(object $message): void
    {
    }
}

class PublicMessageRecorder implements RecordsMessages
{
    use PrivateMessageRecorderCapabilities { record as public; }
}

$recorder = new PublicMessageRecorder();
$recorder->record(new DateTime());

PHPStan reports an issue:

Protected method PublicMessageRecorder::record() overriding public method RecordsMessages::record() should also be public.

While this is allowed by PHP, see: https://3v4l.org/J3ged

Code snippet that reproduces the problem

https://phpstan.org/r/03b14d64-3e97-49bd-a994-3c22570ebde3

Expected output

No errors because this is allowed by PHP, see: https://3v4l.org/J3ged

[ondrejmirtes]

Related: #3465

[ruudk]

It's also impossible to ignore this error via baseline or ignoredErrors.

[ondrejmirtes]

Yeah, that's because when this problem is reported (when it's a real problem), it leads to PHP fatal error, so it makes sense it cannot be baselined.

[ondrejmirtes]

I guess you need to use excludePaths for this file right now.

[ruudk]

That works. Thanks!

[ondrejmirtes]

Fixed: phpstan/phpstan-src@c524c4e

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.