[treatPhpDocTypesAsCertain: false] Call to static method Assert::notNull() with DateTime|null will always evaluate to false.

[ruudk]

Bug report

phpstan/phpstan                         0.12.80
phpstan/phpstan-phpunit                 0.12.17
phpstan/phpstan-strict-rules            0.12.9
phpstan/phpstan-webmozart-assert        0.12.12

$value = null;
$callback = function () use (&$value) : void {
    $value = new DateTime();
};
$callback();

// phpstan: Call to static method Webmozart\Assert\Assert::notNull() with DateTime|null will always evaluate to false.
\Webmozart\Assert\Assert::notNull($value);

Same happens when using PHPUnit's $this->assertNotNull($command); together with phpstan/phpstan-phpunit. So I believe this is not a webmozart / phpunit extension issue.

// phpstan: Call to method PHPUnit\Framework\Assert::assertNotNull() with DateTime|null will always evaluate to false.
$this->assertNotNull($value);

It's interesting because the error correctly says $value is DateTime|null.

Code snippet that reproduces the problem

Not possible as phpstan/phpstan-webmozart-assert is not installed. It would be great if the official extensions could be enabled on the playground.

Expected output

No error.

[mergeable]

This bug report is missing a link to reproduction on phpstan.org.

It will most likely be closed after manual review.

[ruudk]

I see this is marked as easy fix. Do you have any recommendations on how to fix this? I could try to create a PR and fix it myself :)

[ondrejmirtes]

Hi, I thought this would be easily reproducible. This code is equivalent but it doesn't show any error: https://phpstan.org/r/60856b1b-041c-4f7f-bca7-1eb05e228888 Once we have it reproduced with vanilla PHPStan, I'll tell you about the fix. Essentially we'd need MutatingScope::$nativeExpressionTypes to contain the right type guarded by native typehints after the closure... And it's tested with assertNativeType() in NodeScopeResolver::testFileAsserts() (check the list of dataProviders).

[ondrejmirtes]

When you're at it, this one should be really easy to fix: #4650

We just need these lines https://github.com/phpstan/phpstan-src/blob/6f7cadf96c7b55a0df21b51730e4b53ad13a7545/src/Analyser/MutatingScope.php#L757-L758 to call ->getNativeType() if !$this->treatPhpDocTypesAsCertain.

And the test should prove that assertNativeType('bool', $idx === []), not false.

[ruudk]

@ondrejmirtes I'm still not sure how to fix this issue. I fixed the other issue in phpstan/phpstan-src#476 but I cannot reproduce my problem without the phpstan-webmozart-assert on the playground. Any advice on how to proceed?

[ondrejmirtes]

Reproduced: https://phpstan.org/r/f371c7db-7deb-440a-b1f6-398fd8a62ffe

I guess the problem is that somewhere around ImpossibleCheckTypeHelper we should call $scope->getNativeType() instead of $scope->getType().

[ondrejmirtes]

Fixed by: phpstan/phpstan-src#477

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.