The option `treatPhpDocTypesAsCertain` still trust too much the phpdoc

[VincentLanglet]

Bug report

Hi @ondrejmirtes

The option treatPhpDocTypesAsCertain still trust too much the phpdoc. I found two case

• non-empty-array.
• template and generics.

Both examples are in my snippet.

Code snippet that reproduces the problem

https://phpstan.org/r/b0612151-054f-475d-8161-542dd2628f1c

Expected output

No errors, we can be sure about non-empty-array and we can't be sure about generics/template.

[ondrejmirtes]

Hi, I can fix this part [] === $idx, but the problem with return types is out of scope for the treatPhpDocTypesAsCertain option. It was never meant to work with return types, only with incoming parameters to a method. It might start working as the analyser engine gets improved and recognizes this situation, but don't hold your breath for that.

[ondrejmirtes]

Cross-referencing how to fix this: #4657 (comment)

[VincentLanglet]

the problem with return types is out of scope for the treatPhpDocTypesAsCertain option. It was never meant to work with return types, only with incoming parameters to a method. It might start working as the analyser engine gets improved and recognizes this situation, but don't hold your breath for that.

I see, it's not related to Generic/Template but phpdoc @return. I can reproduce the issue without generics:
https://phpstan.org/r/eaa5a98b-3714-4752-8030-6aac498db7ca

I understand why it would not be easy. I prefer to solve the non-empty-array first.

[ondrejmirtes]

Fixed by: phpstan/phpstan-src#476

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.