Template Parameters + non-empty-string bug

[AlexandruGG]

Bug report

Hello, the new 0.12.93 release seems to have introduced a bug regarding non-empty-string and string usage with template parameters.

More specifically, non-empty-string seems to not be properly treated as a subtype of string.

Code snippet that reproduces the problem

https://phpstan.org/r/8ca61235-3da9-49cc-9b61-09b51abc7ee8

Expected output

No error should be reported because it's valid to pass a non-empty-string to something that expects a string. Only the opposite is not allowed.

The same snippet in Psalm shows no error: https://psalm.dev/r/f5871a0f0b

[vhenzl]

I have a similar problem: an array with non-empty-string key can't accept non-empty-string as its key.
PHPStan reports: "Array (array<string, string>) does not accept key string."

Repro: https://phpstan.org/r/e577e855-62ef-448c-8ccf-7a2e0dda538e

[phpstan-bot]

@AlexandruGG After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-PHP 8.0 (1 error)
+PHP 8.0
 ==========
 
-32: Parameter #1 $list of function takesStrings expects Collection<int, string>, Collection<int, non-empty-string> given.
+No errors
 
-PHP 7.4 (2 errors)
+PHP 7.4 (1 error)
 ==========
 
 11: Promoted properties are supported only on PHP 8.0 and later.
-32: Parameter #1 $list of function takesStrings expects Collection<int, string>, Collection<int, non-empty-string> given.
 
 PHP 7.1 – 7.3 (3 errors)
 ==========

Full report

PHP 8.0

No errors

PHP 7.4 (1 error)

Line	Error
11	Promoted properties are supported only on PHP 8.0 and later.

PHP 7.1 – 7.3 (3 errors)

Line	Error
32	Syntax error, unexpected ')' on line 32
32	Syntax error, unexpected T_STRING, expecting T_PAAMAYIM_NEKUDOTAYIM on line 32
32	Syntax error, unexpected T_VARIABLE, expecting ')' on line 32

[ondrejmirtes]

Fixed the issue from OP: phpstan/phpstan-src@6a33de9

@vhenzl Your issue is different, I improved the type verbosity to highlight the problem:

 ------ ---------------------------------------------------------------------
  Line   test.php
 ------ ---------------------------------------------------------------------
  14     Array (array<non-empty-string, string>) does not accept key string.
 ------ ---------------------------------------------------------------------

[ondrejmirtes]

@vhenzl Fixed your problem too: phpstan/phpstan-src@7172e5f

[AlexandruGG]

@ondrejmirtes thank you for fixing this!

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.