Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved wrapping for table output works weird for filename (header) #6724

Closed
schlndh opened this issue Mar 3, 2022 · 3 comments
Closed

Comments

@schlndh
Copy link

schlndh commented Mar 3, 2022

Bug report

On 1.4.7 the new table wrapping now puts a ---------- between lines of table header (e.g. if the filename is too long).

It looks like this:

 ------ --------------------------------------------------------------------------- 
  Line   app/src/Fooooooo/Baaar/Baaaaaz/FooooooBaaarTrait.php (in context of class  
 ------ --------------------------------------------------------------------------- 
         FooooService)                                                              
 ------ --------------------------------------------------------------------------- 
  722    Binary operation "/" between string and 100 results in an error.           
 ------ --------------------------------------------------------------------------- 

Note that the second part of the header is not colored as it used to be. So this seems like an unintended consequence of the new table wrapping.

@ondrejmirtes
Copy link
Member

Hi, i know about this and I think the output is nicer than before. I reported this to Symfony when I found out about this: symfony/symfony#45520

@ondrejmirtes
Copy link
Member

Managed to fix it on PHPStan's side: phpstan/phpstan-src@d921d06

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants