[Console] setColumnMaxWidth does not wrap header cells nicely

[ondrejmirtes]

Symfony version(s) affected

5.4.3, 6.x possibly too

Description

I'd like setColumnMaxWidth to also wrap headers nicely. Currently it adds an extra border between the header lines.

This is how the output currently looks like:

------ ------------------------------------------------------------
  Line   src/Type/JustNullableTypeTrait.php (in context of class
 ------ ------------------------------------------------------------
         PHPStan\Type\StringType)
 ------ ------------------------------------------------------------
  81     Method PHPStan\Type\StringType::doFoo() has no return type
         specified.
 ------ ------------------------------------------------------------

This is how I'd like it to look like:

------ ------------------------------------------------------------
  Line   src/Type/JustNullableTypeTrait.php (in context of class
         PHPStan\Type\StringType)
 ------ ------------------------------------------------------------
  81     Method PHPStan\Type\StringType::doFoo() has no return type
         specified.
 ------ ------------------------------------------------------------

How to reproduce

In context of SymfonyStyle child class:

		$table = $this->createTable();
		$table->setHeaders($headers);
		$table->setRows($rows);
		$table->setColumnMaxWidth(1, 60);

		$table->render();

Possible Solution

No response

Additional Context

No response

[verfriemelt-dot-org]

hey, i can atleast help you with the borders:

<?php

    use Symfony\Component\Console\Helper\TableCell;
    use Symfony\Component\Console\Helper\TableSeparator;
    use Symfony\Component\Console\Output\ConsoleOutput;
    use Symfony\Component\Console\Helper\Table;
    use Symfony\Component\Console\Helper\TableCellStyle;

    include "vendor/autoload.php";

    $table = new Table( new ConsoleOutput() );

    $headerCell = fn( string $content ): TableCell => new TableCell( $content, [ "style" => new TableCellStyle( [ 'fg' => 'green' ] ) ] );

    $table->setRows( [
        [ $headerCell( 'line' ), $headerCell( "src/Type/JustNullableTypeTrait.php (in context of class PHPStan\Type\StringType)" ) ],
        new TableSeparator(),
        [ '81', 'Method PHPStan\Type\StringType::doFoo() has no return type specified.' ],
        [ '81', 'Method PHPStan\Type\StringType::doFoo() has no return type specified.' ],
    ] );

    $table->setColumnMaxWidth( 1, 60 );
    $table->render();

+------+--------------------------------------------------------------+
| line | src/Type/JustNullableTypeTrait.php (in context of class PHPS |
|      | tan\Type\StringType)                                         |
+------+--------------------------------------------------------------+
| 81   | Method PHPStan\Type\StringType::doFoo() has no return type s |
|      | pecified.                                                    |
| 81   | Method PHPStan\Type\StringType::doFoo() has no return type s |
|      | pecified.                                                    |
+------+--------------------------------------------------------------+

the easiest way is to work around the multi-line-headers bug from symfony alltogether, as this would seem to require a lot of refactoring. i had a go at it, but that will get really messy really fast. there seems to be another a bug during the wrapping or somewhere here:

symfony/src/Symfony/Component/Console/Helper/Table.php

Line 546 in ad628ef

$lines = explode("\n", str_replace("\n", "<fg=default;bg=default>\n</>", $cell));

which breaks the styling on multiline headers :|
see here:

maybe there is an easy way to fix this, but i dont have enough experience with the console component ¯\_(ツ)_/¯

and cheers to all your effort with phpstan, maybe this helps a little.