Support for array shape for ArrayAccess classes not working.

[lulco]

Bug report

In #7619 there is mentioned the way how to use array shape for ArrayAccess https://phpstan.org/r/95a7bcea-3198-4297-8770-823861adacfb but it seems it is not working anymore. Can you please check it? Thank you very much.

[ondrejmirtes]

Broke in this PR: phpstan/phpstan-src#1623

[phpstan-bot]

@lulco After the latest push in 1.9.x, PHPStan now reports different result with your code snippet:

@@ @@
+PHP 8.1 (6 errors)
+==========
+
+21: Return type mixed of method Options::offsetGet() is not covariant with tentative return type mixed of method ArrayAccess::offsetGet().
 45: Dumped type: string
+46: Cannot assign offset 'name' to Options<array<string, string>>.
+46: Options<array{name: string}> does not accept string.
+47: Cannot assign offset 'name' to Options<array<string, string>>.
+47: Options<array{name: string}> does not accept int.
+
+PHP 7.1 – 8.0 (5 errors)
+==========
+
+45: Dumped type: string
+46: Cannot assign offset 'name' to Options<array<string, string>>.
+46: Options<array{name: string}> does not accept string.
+47: Cannot assign offset 'name' to Options<array<string, string>>.
 47: Options<array{name: string}> does not accept int.

Full report

PHP 8.1 (6 errors)

Line	Error
21	Return type mixed of method Options::offsetGet() is not covariant with tentative return type mixed of method ArrayAccess::offsetGet().
45	Dumped type: string
46	Cannot assign offset 'name' to Options<array<string, string>>.
46	Options<array{name: string}> does not accept string.
47	Cannot assign offset 'name' to Options<array<string, string>>.
47	Options<array{name: string}> does not accept int.

PHP 7.1 – 8.0 (5 errors)

Line	Error
45	Dumped type: string
46	Cannot assign offset 'name' to Options<array<string, string>>.
46	Options<array{name: string}> does not accept string.
47	Cannot assign offset 'name' to Options<array<string, string>>.
47	Options<array{name: string}> does not accept int.

[VincentLanglet]

I take a look at this and:

• I can confirm the regression is coming from Fix offset access + key-of template type combination phpstan-src#1623
• If I comment the getResult method on the 1.8.3 branch the issue is solved
• If I comment the getResult method on the 1.8.5 branch, the issue is still here
• With git bisect, I discovered that commenting getResult is not enough because of the refacto Simplify TemplateTypeTrait phpstan-src#1705

@rvanvelzen Since both of the PR were made by you, can you help me on this ?
Do you see the issue ?

[phpstan-bot]

@lulco After the latest push in 1.10.x, PHPStan now reports different result with your code snippet:

@@ @@
+PHP 8.1 (6 errors)
+==========
+
+21: Return type mixed of method Options::offsetGet() is not covariant with tentative return type mixed of method ArrayAccess<key-of<TArray of array>,value-of<TArray of array>>::offsetGet().
 45: Dumped type: string
+46: Cannot assign offset 'name' to Options<array<string, string>>.
+46: Options<array{name: string}> does not accept string.
+47: Cannot assign offset 'name' to Options<array<string, string>>.
+47: Options<array{name: string}> does not accept int.
+
+PHP 7.1 – 8.0 (5 errors)
+==========
+
+45: Dumped type: string
+46: Cannot assign offset 'name' to Options<array<string, string>>.
+46: Options<array{name: string}> does not accept string.
+47: Cannot assign offset 'name' to Options<array<string, string>>.
 47: Options<array{name: string}> does not accept int.

Full report

PHP 8.1 (6 errors)

Line	Error
21	Return type mixed of method Options::offsetGet() is not covariant with tentative return type mixed of method ArrayAccess<key-of<TArray of array>,value-of<TArray of array>>::offsetGet().
45	Dumped type: string
46	Cannot assign offset 'name' to Options<array<string, string>>.
46	Options<array{name: string}> does not accept string.
47	Cannot assign offset 'name' to Options<array<string, string>>.
47	Options<array{name: string}> does not accept int.

PHP 7.1 – 8.0 (5 errors)

Line	Error
45	Dumped type: string
46	Cannot assign offset 'name' to Options<array<string, string>>.
46	Options<array{name: string}> does not accept string.
47	Cannot assign offset 'name' to Options<array<string, string>>.
47	Options<array{name: string}> does not accept int.