Checking a type (Null) of a variable

[githubjeka]

Bug report

/** @var null|SomeClass $someVar */
if ($this->check($someVar) // checked ($someVar !== null)
    $someVar->someMethod();

Cannot access $someMethod on SomeClass|null.

P.S. more real example https://phpstan.org/r/8eb1d76d-6ea8-4ab1-aee5-5d2511acb1b7

Expected output

No error

[ondrejmirtes]

Here you go: https://phpstan.org/r/5ddc9309-f64d-44bd-aa7a-cde5b7c12559

Learn more: https://phpstan.org/writing-php-code/narrowing-types#custom-type-checking-functions-and-methods

[githubjeka]

Are there issues that prevent this from being done without introducing additional PHPDoc tags?

[ondrejmirtes]

Performance issues https://phpstan.org/user-guide/troubleshooting-types#what-phpstan-doesn%E2%80%99t-do

[githubjeka]

For me @phpstan-assert-if-true looks redundant, then @var phpDoc tag can be used.
https://phpstan.org/r/78bfdec6-2c64-4e22-9a3b-f0d367bc44fd

In any case, thanks for your work and quick feedback.

[ondrejmirtes]

@var is much worse and I hate it. PHPStan can't verify anything in it, so it's always trusted. It's anti-DRY and very error prone.

[githubjeka]

I didn't think about it. You're right.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.