Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.10.6 release has broken ignore comments in traits #9022

Closed
mvorisek opened this issue Mar 10, 2023 · 4 comments
Closed

1.10.6 release has broken ignore comments in traits #9022

mvorisek opened this issue Mar 10, 2023 · 4 comments

Comments

@mvorisek
Copy link
Contributor

Bug report

As you can see in the repro, @phpstan-ignore-line comment is not ignoring the error on the same line. Only traits are affected, in class, exactly the same method does not emit an error.

In 1.10.5 it worked fine.

Code snippet that reproduces the problem

https://phpstan.org/r/77051602-628e-4970-88b4-c8f267201db7

Expected output

no error

@ondrejmirtes
Copy link
Member

Duplicate of #6175

Inline ignoring in traits needs to be rewritten.

@mvorisek
Copy link
Contributor Author

mvorisek commented Mar 11, 2023

@ondrejmirtes the #6175 issue is from Dec 9, 2021. This issue is about 1.10.6 release which has broken our atk4/core and atk4/data CI pipelines at least. I would be very happy if the newly introduced regression can be fixed quickly or the commit causing this issue reverted.

@mvorisek
Copy link
Contributor Author

Hi @herndlm, this issue is caused by your phpstan/phpstan-src#2279 PR/commit, would you please look at it? It has broken almost all of our repos CI where we use traits with some lines ignored. Thank you.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants