Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looping through functions doesn't detect correct types #9594

Closed
chescos opened this issue Jul 9, 2023 · 2 comments
Closed

Looping through functions doesn't detect correct types #9594

chescos opened this issue Jul 9, 2023 · 2 comments
Labels

Comments

@chescos
Copy link

chescos commented Jul 9, 2023

Bug report

Given the following code:

<?php declare(strict_types = 1);

class HelloWorld
{
	public function sayHello(): void
	{
		$data = [
                    [
                        'elements' => [1, 2, 3],
                        'greet' => fn (int $value) => 'I am '.$value,
                    ],
                    [
                        'elements' => ['hello', 'world'],
                        'greet' => fn (string $value) => 'I am '.$value,
                    ],
                ];
        
                foreach ($data as $entry) {
                    foreach ($entry['elements'] as $element) {
                        $entry['greet']($element);
                    }
                }
	}
}

Shouldn't PHPStan detect that the data types of the array elements match the function parameter?

Code snippet that reproduces the problem

https://phpstan.org/r/dfcecd96-e249-4263-8dba-772224daf7fc

Expected output

The issue was reported incorrectly.

Did PHPStan help you today? Did it make you happy in any way?

No response

@ondrejmirtes
Copy link
Member

Fixed: phpstan/phpstan-src#2902

Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants