Skip to content

Conversation

mad-briller
Copy link
Contributor

@phpstan-bot
Copy link
Collaborator

You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x.

@mad-briller mad-briller changed the base branch from 1.11.x to 1.10.x February 2, 2024 18:07
@ondrejmirtes
Copy link
Member

Awesome! This fixes a bunch of issues (https://github.com/phpstan/phpstan-src/actions/runs/7974759948):

Please add regression tests for them - I think type inference tests in NodeScopeResolverTest should be fine. Please put the new files in dataFileAsserts in random places and not at the end, it makes the merge conflict to be less probable :)

@mad-briller
Copy link
Contributor Author

mad-briller commented Feb 20, 2024

@ondrejmirtes i've investigated the those issues and found that phpstan/phpstan#3818 appears to be an issue regarding the application of @var phpdocs, and is not fixed by this. However there is an additional try link provided in that issue that is resolved so i've added that as a regression test but this change doesn't close the issue.

however all the others are solved by this change! 🎉 you love to see it

@ondrejmirtes ondrejmirtes merged commit ffa7686 into phpstan:1.10.x Feb 20, 2024
@ondrejmirtes
Copy link
Member

Awesome, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

array_map ignores union of callables
3 participants