Validate phpDoc throws types #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Majkl578 I'm not sure it's a good idea. People may want to put there just marker interface in PHP < 7 codebase, i.e the marker interface cannot extend |
JanTvrdik
reviewed
May 12, 2018
| } | ||
|
|
||
| return [sprintf( | ||
| 'PHPDoc tag @throws with type %s is not a valid throwable (incompatible with Throwable)', |
There was a problem hiding this comment.
That's a very odd formulation. How about simply ...type $s is not subtype of Throwable?
|
I'm quite sure it's a good idea.
https://docs.phpdoc.org/references/phpdoc/tags/throws.html#description Also PHP 5 code is an edge case. (Btw I've never seen such case.) |
|
Reworded. 👍 |
|
Nice, thank you! |
|
Small note here on Guzzle, after updating to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation for
@throwsto make sure thrown type is a Throwable.cc @pepakriz