NodeScopeResolver refactored 🎉 #1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 2, 2019
Closed
|
This will fix at least 24 issues once finished and merged 🎉 |
ondrejmirtes
force-pushed
the
nsr-refactoring
branch
2 times, most recently
from
1d13000
to
97b7ade
Compare
|
Awesome! Not sure how informative this is but I just ran it on my most recent project and it succeeded (as it should have) without any errors. |
|
That's great! I'm now testing 1st party packages and then I check some open-source and private codebases that use PHPStan :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.