Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting type from clone operator #47

Closed
wants to merge 2 commits into from

Conversation

pepakriz
Copy link
Contributor

No description provided.

@ondrejmirtes
Copy link
Member

It'd be nice if it cloned only objects (e.g. $type->getClass() !== null) + if there was a rule to check if we are cloning MixedType or type with getClass() !== null. It could be on level 3 or 4.

Cloning anything other than an object results in fatal error: https://3v4l.org/ZmorQ I'd like the test example to be valid.

@pepakriz pepakriz force-pushed the clone-type branch 3 times, most recently from 1073fa0 to dfb0e1b Compare December 26, 2016 14:39
@pepakriz
Copy link
Contributor Author

PR Updated. I'm not sure about naming, so check it and give feedback please.

@ondrejmirtes
Copy link
Member

Merged as 97f0d45 and 7ffd895. I improved the latter commit a little bit. Thanks!

@ondrejmirtes
Copy link
Member

@pepakriz BTW There was quite a bad mistake in your PR - both PHPUnit and PHPStan died during build: f9176d0

@ondrejmirtes
Copy link
Member

Also I like to add namespaces to all test files so there can be multiple classes called Foo etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants