-
-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UnionIterableType: fix getClass
method
#51
UnionIterableType: fix getClass
method
#51
Conversation
{ | ||
foreach ($this->otherTypes as $otherType) { | ||
if ($otherType->getClass() !== null) { | ||
return $otherType->getClass(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like it to return null if there are multiple other types with getClass() !== null
, not the first one.
@@ -105,7 +105,7 @@ public function canAccessProperties(): bool | |||
|
|||
public function canCallMethods(): bool | |||
{ | |||
return $this->class !== 'stdClass'; | |||
return strtolower($this->class) !== strtolower('stdClass'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please write stdclass
:)
69ef424
to
3ac601e
Compare
PR Updated |
Thanks, good job! 👍 |
No description provided.