[FEATURE] add --all option #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/cleanup-dry-run #46 +/- ##
=============================================================
- Coverage 84.37% 84.21% -0.17%
- Complexity 300 302 +2
=============================================================
Files 32 32
Lines 832 836 +4
=============================================================
+ Hits 702 704 +2
- Misses 130 132 +2
Continue to review full report at Codecov.
|
Kanti
force-pushed
the
feature/all-option
branch
from
10d2521
to
ec83af3
Compare
ChrisB9
reviewed
Jan 26, 2019
| * @return string[] | ||
| */ | ||
| public function syncCommands(string $from, string $to, string $currentHost): array | ||
| public function syncCommands(string $from, string $to, string $currentHost, bool $all): array |
There was a problem hiding this comment.
i think the bool $all should have a default value, per default it should sync everything
|
included in #50. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
--alloption to ignore excludes