PHP 7.3 compatibility and testing #68
Conversation
Instead of throwing a `ParseError`, the API specifies, that a `PHPTal_PHPTAL_TemplateException` should be thrown instead.
…hat is now reported as warning
|
@Potherca @shivashanti @jacekkarczmarczyk @monojp can I ask you to glance over this? If it looks good, I'll go ahead and tag |
| @@ -23,13 +23,16 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": ">=5.1.2" | |||
| "php": "^7.1.0" | |||
There was a problem hiding this comment.
This is intentional: please check http://doctrine-project.org/2017/07/25/php-7.1-requirement-and-composer.html
There was a problem hiding this comment.
@Ocramius can’t php be “^5.3.2|^7.0”?
There was a problem hiding this comment.
PHP 5 is too old but this library users seems to have existing older servers.
There was a problem hiding this comment.
Yeah, but older versions would continue to run. This release is about fixing support for stable PHP versions.
If we don't test against a PHP version, we can't consider it "supported", hence the restriction in first place.
There was a problem hiding this comment.
I think there is no problem if the set to --ignore-platform-reqs
There was a problem hiding this comment.
Please don't use that :-P https://twitter.com/Ocramius/status/1108306630855278592
can't be removed? |
|
@tanakahisateru I didn't clean up code in this patch - don't have time for it right now, and what's more pressing is the support for newer releases. Anyone willing to take on the endeavor of improving the code quality of PHPTAL is welcome to do so with further patches (better if we target 2.0 for those though) |
|
Right, shipping this, but will not merge to
|
Fixes #64
Rebases #64 and introduces CI entries for PHP 5.6~7.3