Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure optsConfig returns an array if unset #72

Closed
wants to merge 4 commits into from
Closed

Ensure optsConfig returns an array if unset #72

wants to merge 4 commits into from

Conversation

elliot-sawyer
Copy link
Contributor

fixes #71

@elliot-sawyer elliot-sawyer changed the base branch from master to 4.0 July 28, 2021 00:11
@phptek
Copy link
Owner

phptek commented Jul 28, 2021

Legend. Thanks mate.

@phptek
Copy link
Owner

phptek commented Jul 28, 2021

Can you make your PR against the 4.0 branch please? Then I'll tag and release 4.0.1

@elliot-sawyer elliot-sawyer changed the base branch from master to 4.0 July 28, 2021 02:32
@elliot-sawyer
Copy link
Contributor Author

Not sure why it's included those 3 unrelated changes from you, but I've updated it to target 4.0 branch instead

@phptek
Copy link
Owner

phptek commented Jul 28, 2021

You'll need to rebase your feature branch against upstream 4.0 (assuming you've pulled the latest from 4.0 first)

@elliot-sawyer elliot-sawyer deleted the bugfix/opts-array branch July 28, 2021 03:48
@elliot-sawyer
Copy link
Contributor Author

See #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants