Skip to content

Commit

Permalink
Merge pull request #365 from Jan-E/appveyor_3_tests
Browse files Browse the repository at this point in the history
Appveyor enable 3 extra tests
  • Loading branch information
stesie committed Jul 13, 2018
2 parents 4762dd1 + 61f98e2 commit 42e907c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
6 changes: 5 additions & 1 deletion appveyor.yml
Expand Up @@ -41,6 +41,10 @@ install:
- cd deps
- curl -fSL -o %V8_ASSETS% "https://s3.amazonaws.com/win-phpv8/%V8_ASSETS%"
- 7z.exe x %V8_ASSETS%
- curl -fSL -o libiconv.zip "https://windows.php.net/downloads/php-sdk/deps/vc14/%Platform%/libiconv-1.15-vc14-%Platform%.zip"
- 7z.exe x libiconv.zip -y
- curl -fSL -o libxml2.zip "https://windows.php.net/downloads/php-sdk/deps/vc14/%Platform%/libxml2-2.9.8-vc14-%Platform%.zip"
- 7z.exe x libxml2.zip -y
- cd ..
- curl -fSL -o "php-%PHP_VERSION%.tar.gz" "https://github.com/php/php-src/archive/php-%PHP_VERSION%.tar.gz"
- ren php php-src-php-%PHP_VERSION%
Expand Down Expand Up @@ -68,7 +72,7 @@ build_script:
- echo Building PHP [%PHP_VERSION%]
- '%PHP_SDK%\bin\phpsdk_setvars'
- buildconf
- configure --disable-all --enable-cli --with-v8js %CONFIGURE_EXTRA%
- configure --disable-all --enable-cli --with-iconv=yes --with-libxml=yes --with-dom=yes --enable-json=static --with-v8js %CONFIGURE_EXTRA%
- nmake

after_build:
Expand Down
6 changes: 0 additions & 6 deletions tests/extensions_error.phpt
Expand Up @@ -9,12 +9,6 @@ phpinfo(INFO_MODULES);
$minfo = ob_get_contents();
ob_end_clean();

if(strtoupper(substr(PHP_OS, 0, 3)) == 'WIN') {
// On Windows the "Fatal error" happens to appear before the error
// message output by V8 itself.
echo "skip Windows";
}

if(preg_match("/V8 Engine Linked Version => (.*)/", $minfo, $matches)) {
$version = explode('.', $matches[1]);
if($version[0] < 5 || ($version[0] == 5 && $version[1] < 7)) {
Expand Down

0 comments on commit 42e907c

Please sign in to comment.