Fix for V8 timezone notification, PHP7.x #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redbullmarky
changed the title
|
I suppose we should increase the minimum supported V8 version then, shouldn't we? Currently the README says 6.9.something The other PR is some more involved checking versions. Not that I think we should do the version checking, since those V8 versions are pretty old anyways I'd just adjust README and config.m4 accordingly |
|
@stesie I had a poke around to see when that particular change was made but I'm not sure; i'm playing around with V8 9.5 at the moment. V8 7.4 seems to be where the function was moved from Date to the isolate, removed in 7.7, according to: and it looks like the original PR was based around 7.5. |
This was referenced May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #378 and closes #396, php7
Additional parameter supplied to DateTimeConfigurationChangeNotification as per link below; re-enabled the relevant test.
https://v8docs.nodesource.com/node-12.0/d4/df7/classv8_1_1_date.html#a85083f8170083de4389d798cbce02c44