Fix to work with nested elements with periods #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upstream/master: add file target; satisfies phrawzty#5
Closed
|
Not a bad idea, but this is really just a case of replacing one relatively arbitrary symbol with another though, isn't it ? Perhaps instead of specifying a character in particular, it would be more useful to allow any given character to be specified via an argument - that way it works for whatever situation. I'm going to close this request in favour of the feature I've just described above (see issue #7). |
|
I just pushed this feature to the devel branch; if it works for you, I'll go ahead and merge proper. Please let me know. |
|
@phrawzty Looks great. Thanks for working with me on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use a "*" instead of a "." to flatten elements, then we can deal with elements that contain periods. I've tested this with a Java app which outputs JSON for monitoring and it works.