Make it possible to drop any item from trees #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. I'd say we go ahead and approve this and pull it in and can make any changes that are needed. |
lunarsoap5
approved these changes
Feb 28, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #6 to allowing a tree to drop any item. Note to do this, you must set the drop_id in the tree's ZMB entry to the item id you want to drop OR'd with 0x8000 (i.e. the 16-bit item_id you want with its MSB set).
Unfortunately I had to use assembly for this, as I needed to reuse existing code to do this. However, with the exception of one line, all of the assembly is based on existing routines, so we can treat it more or less as a black box.