Merge pull request #25 from phug-php/add-tests

Add tests
phug-php · Jul 4, 2018 · 54a0238 · 54a0238
2 parents 87f976c + 1e0a3e7
commit 54a0238
Show file tree

Hide file tree

Showing 5 changed files with 51 additions and 22 deletions.
diff --git a/src/Phug/Renderer.php b/src/Phug/Renderer.php
@@ -148,7 +148,7 @@ function ($path) {
      *
      * @return bool
      */
-    public function renderAndWriteFile($inputFile, $outputFile, $parameters)
+    public function renderAndWriteFile($inputFile, $outputFile, array $parameters = [])
     {
         $outputDirectory = dirname($outputFile);
 

diff --git a/tests/Phug/AbstractRendererTest.php b/tests/Phug/AbstractRendererTest.php
@@ -208,4 +208,24 @@ public static function assertSameLines($expected, $actual, $message = null)
 
         self::assertSame($expected, $actual, $message);
     }
+
+    protected static function getReadOnlyDirectory()
+    {
+        $dir = __DIR__;
+        while (is_writable($dir)) {
+            $parent = realpath($dir.'/..');
+            if ($parent === $dir) {
+                $dir = 'C:';
+                if (!file_exists($dir) || is_writable($dir)) {
+                    self::markTestSkipped('No read-only directory found to do the test');
+
+                    return;
+                }
+                break;
+            }
+            $dir = $parent;
+        }
+
+        return $dir;
+    }
 }
diff --git a/tests/Phug/Adapter/FileAdapterTest.php b/tests/Phug/Adapter/FileAdapterTest.php
@@ -538,22 +538,8 @@ public function testMissingDirectory()
      */
     public function testReadOnlyDirectory()
     {
-        $dir = __DIR__;
-        while (is_writable($dir)) {
-            $parent = realpath($dir.'/..');
-            if ($parent === $dir) {
-                $dir = 'C:';
-                if (!file_exists($dir) || is_writable($dir)) {
-                    self::markTestSkipped('No read-only directory found to do the test');
-
-                    return;
-                }
-                break;
-            }
-            $dir = $parent;
-        }
         $renderer = new Renderer([
-            'cache_dir' => $dir,
+            'cache_dir' => static::getReadOnlyDirectory(),
         ]);
         $renderer->render(__DIR__.'/../../cases/attrs.pug');
     }

diff --git a/tests/Phug/ProfilerModuleTest.php b/tests/Phug/ProfilerModuleTest.php
@@ -404,12 +404,6 @@ public function testEventVarDump()
             return;
         }
 
-        if (version_compare(PHP_VERSION, '7.1.0') >= 0) {
-            self::markTestSkipped('var_dump test disabled for PHP '.PHP_VERSION.'.');
-
-            return;
-        }
-
         $renderer = new Renderer([
             'enable_profiler' => true,
         ]);

diff --git a/tests/Phug/RendererTest.php b/tests/Phug/RendererTest.php
@@ -72,10 +72,39 @@ public function testRenderDirectory()
         self::assertFileExists($directory.'/subdirectory/subsubdirectory/basic.html');
         self::assertFileExists($directory.'/subdirectory/subsubdirectory/blanks.html');
 
+        self::emptyDirectory($directory);
+        file_put_contents("$directory/foo.pug", 'p=foo');
+
+        list($success, $errors) = $this->renderer->renderDirectory($directory, ['foo' => 'bar']);
+
+        self::assertSame(0, $errors);
+        self::assertSame(1, $success);
+        self::assertFileExists("$directory/foo.html");
+        self::assertSame('<p>bar</p>', trim(file_get_contents("$directory/foo.html")));
+
+        self::emptyDirectory($directory);
+        file_put_contents("$directory/foo.pug", 'p=foo');
+
+        list($success, $errors) = $this->renderer->renderDirectory($directory, null, ['foo' => 'bar']);
+
+        self::assertSame(0, $errors);
+        self::assertSame(1, $success);
+        self::assertFileExists("$directory/foo.html");
+        self::assertSame('<p>bar</p>', trim(file_get_contents("$directory/foo.html")));
+
         self::emptyDirectory($directory);
         @rmdir($directory);
     }
 
+    /**
+     * @covers ::renderAndWriteFile
+     */
+    public function testRenderAndWriteFile()
+    {
+        self::assertFalse($this->renderer->renderAndWriteFile(__DIR__.'/../utils/error.pug', static::getReadOnlyDirectory().'/output.html'));
+        self::assertFalse($this->renderer->renderAndWriteFile(__DIR__.'/../utils/error.pug', static::getReadOnlyDirectory().'/foobar/output.html'));
+    }
+
     /**
      * @covers ::displayFile
      * @covers ::display