RFC: Change Version Scheme for baseimage-docker

[Theaxiom]

I am proposing we change the version scheme for the tagging of baseimage-docker container images to match the version of LTS Ubuntu which it is built from and attach our semantic version.

Here is one idea:

• phusion/baseimage-docker:18.04-1.0.0

Any additional feedback is welcomed! I would like to solidify this before we cut the next release.

[Theaxiom]

I feel that we are well past "Version 1.0" of baseimage-docker and should graduate to a more mature versioning scheme, this is why I have proposed the above.

[kingdonb]

I think that semver is awesome, and there are some tools which do automation on semver that insist your tags must be rigidly semver without deviating.

18.04-1.0.0 does not parse in a semver context. 18.04 is also not semver.

I am not sure that it matters here, as the context I'm thinking of in particular is fluxcd, and you are not expected to run an unmodified baseimage-docker in any real environment. So it might be more important for our tags to communicate something clearly, which 18.04-1.0.0 does nicely.

[Theaxiom]

Thanks for the input!

…

On Tue, Oct 22, 2019, 11:29 AM Kingdon Barrett ***@***.***> wrote: I think that semver is awesome, and there are some tools which do automation on semver that insist your tags must be rigidly semver without deviating. 18.04-1.0.0 does not parse in a semver context. 18.04 is also not semver. I am not sure that it matters here, as the context I'm thinking of in particular is fluxcd, and you are not expected to run an unmodified baseimage-docker in any real environment. So it might be more important for our tags to communicate something clearly, which 18.04-1.0.0 does nicely. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#543?email_source=notifications&email_token=AAAN5NLEISRK2GDCAKSS5J3QP5BBXA5CNFSM4JDFPIJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB6XS5Q#issuecomment-545094006>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAN5NNER3UV6UAZ4ZUISFTQP5BBXANCNFSM4JDFPIJQ> .

[rdeavila]

Maybe this adds more complexity, but an alternative is removing the 18.04 part from the tag, and add to the image name, like phusion/baseimage-docker-18.04:1.0.0 or phusion/baseimage-docker:20.04-1.0.0.

[Theaxiom]

@rdeavila if we go based on standard Docker community established conventions (looking at common container images available on Docker Hub) we can see that the convention is to keep it in the tag.

[brandonkal]

I would suggest:

• phusion/baseimage-docker:bionic-1.0.0
• phusion/baseimage-docker:cosmic-1.0.0

Easier to read and more in line with the official ubuntu image tags.

[Theaxiom]

@brandonkal I like your recommendation. If anyone else is in favor, give it a thumbs up.

[Theaxiom]

Implementing new version strategy based on @brandonkal suggestion.

[SuperSandro2000]

The official ubuntu image tags are:

18.04, bionic-20200403, bionic
19.10, eoan-20200410, eoan
20.04, focal-20200423, focal, latest, rolling
20.10, groovy-20200505, groovy, devel
14.04, trusty-20191217, trusty
16.04, xenial-20200326, xenial

So to be inline with official tags would mean to at least have the number and the name. Not one or the other.

[Theaxiom]

@SuperSandro2000 I don't think it is necessary to go beyond bionic-1.0.0 as if you look at the Docker Hub for Ubuntu you will see that we can build from the bionic tag and we are not doing any regular/nightly builds.

I see your point regarding security updates though, it would be nice to know which image it was built from, but you can determine that from the date the image was built. It would in some sense be redundant, it would also make it so we cannot automate the build process as easily. and have super-long image tags.

Anyone else have input regarding this?

[SuperSandro2000]

I did not mean that this image needs nightly builds or support every version of Ubuntu. I wanted to say that I would prefer two tags: bionic-1.0.0 and 18.04-1.0.0 for the same image.

[Theaxiom]

@SuperSandro2000 that's certainly reasonable. I did not mean to imply that you had indicated nightly builds, I was stating that if we were to be doing nightly builds, we would include the 20200403 portion of the version in our tags. I will release two tags based on your input:

• bionic-1.0.0
• 18.04-1.0.0

[Theaxiom]

@SuperSandro2000 Just wanted to let you know I do appreciate your feedback and I agree entirely with you, I'v been super stressed at work lately and I should not allow it to affect my pragmatism. I hope to have the CI/CD pipeline working properly soon and have already made some recent changes to that effect. We use GitLab CI at work and I just haven't had the time to really take a deep dive into Travis CI, ironically enough it is named after me.

I just pushed up the new version.

[Theaxiom]

@SuperSandro2000 CI pipeline is fixed, builds are fully automated now. 👍

Thank you for the inspiration and motivation! <3