Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change version from 16.04 to 18.04 #505

Merged
merged 2 commits into from
Sep 12, 2018
Merged

change version from 16.04 to 18.04 #505

merged 2 commits into from
Sep 12, 2018

Conversation

awkj
Copy link
Contributor

@awkj awkj commented Aug 21, 2018

No description provided.

@kingdonb
Copy link
Collaborator

It's also here

<a name="upgrading_os"></a>
### Upgrading the operating system inside the container

Baseimage-docker images contain an Ubuntu 16.04 operating system.

... in README.md -- it looks like this text is not present in the Chinese versions.

Please update the PR and we'll merge it. Thanks!

Copy link
Collaborator

@kingdonb kingdonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 318 of README.md also has a 16.04 that needs to be changed

@kingdonb
Copy link
Collaborator

It looks like the CI might have lost the dockerhub creds again:


The command "env NAME=${NAME} VERSION=${VERSION} ./test/runner.sh" exited with 0.
$ docker login -u "${DOCKER_USERNAME}" -p "${DOCKER_PASSWORD}"; docker push ${NAME}:${VERSION};
Login with your Docker ID to push and pull images from Docker Hub. If you don't have a Docker ID, head over to https://hub.docker.com to create one.
Username: 

@PikachuEXE
Copy link
Contributor

I think there are 2 places on each readme doc that mention the version of ubuntu
So still "Changes requested"

Copy link
Collaborator

@Theaxiom Theaxiom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@Theaxiom Theaxiom added this to the 0.11.1 milestone Sep 12, 2018
@Theaxiom Theaxiom merged commit 14d156c into phusion:master Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants