Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiarch implementation for amd64, arm64 and arm32 #534

Merged
merged 1 commit into from
May 30, 2019

Conversation

CodeCutterUK
Copy link
Contributor

As promised in #518 here is a potential change to support multiple architectures.

I couldn't see a next branch as per contribution guidelines so based this off of master instead.

@CodeCutterUK
Copy link
Contributor Author

I might be able to change this to store the individual builds with Travis until the manifest is deployed, which would get around needing the Docker username and password, but will await initial feedback

@kingdonb
Copy link
Collaborator

I would like to take some time to review this, but unfortunately don't have access to any ARM hosts or other than AMD64 right now, for at least several months. Is there someone who can vouch for this who has some of the architectures in question?

@Theaxiom
Copy link
Collaborator

@CodeCutterUK yeah sorry, contribution guidelines need to be updated -- we don't have next branch anymore as it is simplified with trunk-based development (feature/task-based branching) flow. We really appreciate the contribution, I am tempted to just merge it in and then fail forward if it doesn't work. What do you think @kingdonb ?

Copy link
Collaborator

@Theaxiom Theaxiom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@CodeCutterUK
Copy link
Contributor Author

Happy to fix forward....only thing to be aware of is that I can't test the Docker Hub publication parts, so might be worth double checking the publish to latest & master parts work as expected and don't overwrite anything.

@Theaxiom Theaxiom merged commit b5c34e9 into phusion:master May 30, 2019
@Theaxiom Theaxiom added this to the 0.11.1 milestone May 30, 2019
@Theaxiom
Copy link
Collaborator

Changes have been merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants