Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further improvements to the multi-arch build #535

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Further improvements to the multi-arch build #535

merged 1 commit into from
Jun 11, 2019

Conversation

CodeCutterUK
Copy link
Contributor

  • Ensure building multiarch works when the image name isn't overridden
  • Ensure environment parameters are correctly passed to the multi-arch build script
  • Stop tagging arch specific containers with latest when running the make release step

@CodeCutterUK
Ensure building multiarch works when the image name isn't overridden
9c9ffde 
Stop tagging latest by when running the make release step
Theaxiom
Theaxiom approved these changes Jun 11, 2019
View reviewed changes
Copy link
Collaborator

@Theaxiom Theaxiom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@Theaxiom Theaxiom merged commit c87dcdf into phusion:master Jun 11, 2019
@Theaxiom Theaxiom added this to the 0.11.1 milestone Jun 11, 2019
@Theaxiom
Copy link
Collaborator

Thank you for your contributions @CodeCutterUK !

@CodeCutterUK CodeCutterUK deleted the multi-arch-build branch June 18, 2019 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Theaxiom Theaxiom Theaxiom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
bionic-1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CodeCutterUK @Theaxiom