Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove riscv64 from build platforms #633

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

das7pad
Copy link
Contributor

@das7pad das7pad commented Feb 16, 2024

Description of the change

I'm hoping this will unblock the release of jammy-1.0.2.

The docker image ubuntu:22.04 is not available for riscv64, which limits options for providing support for it here.

------
 > [linux/riscv64 internal] load metadata for docker.io/library/ubuntu:22.04:
------
Dockerfile:2
--------------------
   1 |     ARG BASE_IMAGE=ubuntu:22.04
   2 | >>> FROM $BASE_IMAGE
   3 |     
   4 |     ARG QEMU_ARCH
--------------------
ERROR: failed to solve: ubuntu:22.04: no match for platform in manifest: not found
Error: buildx failed with: ERROR: failed to solve: ubuntu:22.04: no match for platform in manifest: not found

Benefits

Unblocks release?

Possible drawbacks

cc @olof-nord who added this in 2021 via #604, back then the release was focal.

Applicable issues

#632

Additional information

The docker image `ubuntu:22.04` is not available for `riscv64`, which limits options for providing support for it here.
Copy link
Collaborator

@samip5 samip5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks riscv64, but the newer ubuntu is not available for it so YOLO.

@samip5 samip5 merged commit f69b7c6 into phusion:master Feb 16, 2024
@das7pad das7pad deleted the patch-1 branch February 16, 2024 11:56
@olof-nord
Copy link
Contributor

You are the ones in charge of the project, no questions asked.
I do see this as a step backwards though, as risc-v is supported by Ubuntu 22.04.3 as well as 23.10.

https://ubuntu.com/download/risc-v

For risc-v docker Ubuntu images, I use https://hub.docker.com/r/riscv64/ubuntu at the moment.

@das7pad
Copy link
Contributor Author

das7pad commented Feb 19, 2024

I've opened #634 with an attempt to bring back support for riscv64. Cross-posting:

It is worth noting that the riscv64/ubuntu:22.04 image was last built in December 2022, so more than a year ago. It does not look supported anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants