Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx_config_template in Passengerfile.json is not using relative path #1557

Closed
kriansa opened this issue Jul 7, 2015 · 3 comments
Closed
Assignees
Milestone

Comments

@kriansa
Copy link

kriansa commented Jul 7, 2015

If you start passenger not by app root (where Passengerfile.json is located) then passenger standalone won't be able to find nginx_config_template, so you'll have to set manually by using --nginx-config-template in your command-line.

@FooBarWidget FooBarWidget added this to the 5.0.14 milestone Jul 7, 2015
@FooBarWidget
Copy link
Member

We'll have a look at this. For now, you can work around this issue with absolute paths.

@FooBarWidget FooBarWidget self-assigned this Jul 8, 2015
@FooBarWidget
Copy link
Member

This has been fixed in commit 900f3e6.

@OnixGH
Copy link
Contributor

OnixGH commented Aug 11, 2015

This commit breaks the Node.js loader's loadApplication(), because startupFile is now sometimes absolute, appRoot was already absolute, so you get require("/home/user/app/"+"/home/user/app/x.js").

var startupFile = PhusionPassenger.options.startup_file || 'app.js';
require(appRoot + '/' + startupFile);

@OnixGH OnixGH reopened this Aug 11, 2015
@FooBarWidget FooBarWidget modified the milestones: 5.0.16, 5.0.14 Aug 13, 2015
@OnixGH OnixGH closed this as completed in 9879d05 Aug 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants